Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: canonicalize catalog and schema names #3600

Merged

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Mar 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Before this patch, the following SQL will fail:

USE INFORMATION_SCHEMA;

Unknown database 'INFORMATION_SCHEMA'.

We must always treat the catalog and schema in lowercase.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@killme2008 killme2008 marked this pull request as ready for review March 27, 2024 21:21
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 27, 2024
@killme2008 killme2008 added the C-bug Category Bugs label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 84.96%. Comparing base (92a8e86) to head (a703f9d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3600      +/-   ##
==========================================
- Coverage   85.35%   84.96%   -0.39%     
==========================================
  Files         931      931              
  Lines      154611   154618       +7     
==========================================
- Hits       131961   131366     -595     
- Misses      22650    23252     +602     

Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun added this pull request to the merge queue Mar 28, 2024
Merged via the queue into GreptimeTeam:main with commit e3b37ee Mar 28, 2024
29 of 40 checks passed
@killme2008 killme2008 deleted the feature/catalog-schema-lowercase branch March 28, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category Bugs docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants