-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move manifest manager lock to MitoRegion
#3689
refactor: Move manifest manager lock to MitoRegion
#3689
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3689 +/- ##
==========================================
- Coverage 85.57% 85.26% -0.32%
==========================================
Files 957 962 +5
Lines 159226 160265 +1039
==========================================
+ Hits 136258 136644 +386
- Misses 22968 23621 +653 |
6d57942
to
cd79193
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3456
What's changed and what's your intention?
This PR is a part of #3456
It moves methods in
RegionManifestManagerInner
toRegionManifestManager
. Now theMitoRegion
uses a lock to protect the manager. We can use that lock to ensure there is only one task updating manifest andVersionControl
.Checklist