-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support evaluate expr in range query param #3823
Merged
waynexia
merged 4 commits into
GreptimeTeam:main
from
Taylor-lagrange:feat-range-to-expr
May 17, 2024
Merged
feat: support evaluate expr in range query param #3823
waynexia
merged 4 commits into
GreptimeTeam:main
from
Taylor-lagrange:feat-range-to-expr
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3823 +/- ##
==========================================
- Coverage 86.00% 85.66% -0.34%
==========================================
Files 963 963
Lines 164516 164627 +111
==========================================
- Hits 141489 141029 -460
- Misses 23027 23598 +571 |
github-actions
bot
added
docs-required
This change requires docs update.
and removed
docs-not-required
This change does not impact docs.
labels
Apr 29, 2024
waynexia
reviewed
Apr 29, 2024
Taylor-lagrange
force-pushed
the
feat-range-to-expr
branch
from
April 30, 2024 02:10
598b3ec
to
f3001a4
Compare
evenyag
reviewed
Apr 30, 2024
Closed
Taylor-lagrange
force-pushed
the
feat-range-to-expr
branch
from
May 10, 2024 02:02
a62e33b
to
d7e3ec0
Compare
evenyag
approved these changes
May 11, 2024
Taylor-lagrange
force-pushed
the
feat-range-to-expr
branch
from
May 13, 2024 02:00
d7e3ec0
to
a30de61
Compare
@waynexia Please take a look. |
waynexia
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
May 21, 2024
* feat: support evaluate expr in range query param * chore: fix comment * chore: fix code comment * fix: disbale now in duration param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Support use expr can be evaluate at logical plan stage (e.g.
INTERVAL '2' day - INTERVAL '1' day
)Support case like:
Please explain IN DETAIL what the changes are in this PR and why they are needed:
ExprSimplifier
to evaluate expr in range query plan rewrite stageChecklist