Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: correct RepeatedField origin #3838

Merged
merged 2 commits into from
Apr 30, 2024
Merged

chore: correct RepeatedField origin #3838

merged 2 commits into from
Apr 30, 2024

Conversation

tisonkun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

TRIVIAL AS IS

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@tisonkun tisonkun requested review from fengjiachun and v0y4g3r April 29, 2024 09:59
@tisonkun tisonkun requested a review from a team as a code owner April 29, 2024 09:59
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 29, 2024
v0y4g3r
v0y4g3r approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun
fixup
0cc4d3f 
Signed-off-by: tison <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 85.44%. Comparing base (336db38) to head (0cc4d3f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3838      +/-   ##
==========================================
- Coverage   85.78%   85.44%   -0.34%     
==========================================
  Files         950      950              
  Lines      162714   162714              
==========================================
- Hits       139582   139037     -545     
- Misses      23132    23677     +545

@tisonkun tisonkun requested review from killme2008 and waynexia April 29, 2024 12:02
@tisonkun tisonkun enabled auto-merge April 29, 2024 13:07
waynexia
waynexia approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

src/servers/src/repeated_field.rs Show resolved Hide resolved
@tisonkun tisonkun added this pull request to the merge queue Apr 30, 2024
Merged via the queue into GreptimeTeam:main with commit d11b1fa Apr 30, 2024
21 checks passed
@tisonkun tisonkun deleted the correct-RepeatedField-origin branch April 30, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@v0y4g3r v0y4g3r v0y4g3r approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

@killme2008 killme2008 Awaiting requested review from killme2008

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisonkun @v0y4g3r @waynexia