Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update region Version in the worker loop #4114

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Jun 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR sends a notification to the worker loop after the manifest manager stores the update action. The worker will apply the update to the region Version.

It ensures the version is updated in the worker loop. If we update the version in another thread, then we might not have a consistent view of the version in the worker loop.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 6, 2024
@waynexia
Copy link
Member

waynexia commented Jun 6, 2024

⚡ blazing cool!

@evenyag evenyag marked this pull request as ready for review June 7, 2024 02:58
@evenyag evenyag requested review from v0y4g3r and waynexia as code owners June 7, 2024 02:58
@evenyag evenyag requested a review from WenyXu June 7, 2024 02:58
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 58.08824% with 57 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (09e0e1b) to head (2e2d3bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4114      +/-   ##
==========================================
- Coverage   85.40%   85.09%   -0.32%     
==========================================
  Files         994      994              
  Lines      173970   173994      +24     
==========================================
- Hits       148587   148066     -521     
- Misses      25383    25928     +545     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, exquisite design!

@evenyag evenyag added this pull request to the merge queue Jun 7, 2024
Merged via the queue into GreptimeTeam:main with commit e982d2e Jun 7, 2024
42 checks passed
@evenyag evenyag deleted the fix/update-version branch June 7, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants