-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split up different stmts #4997
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
1ecf97d
to
ab95751
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4997 +/- ##
==========================================
- Coverage 84.01% 83.75% -0.27%
==========================================
Files 1149 1149
Lines 214810 214997 +187
==========================================
- Hits 180474 180066 -408
- Misses 34336 34931 +595
|
There are some conflicts |
ab95751
to
d1a5de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e5f651a
to
82d3d5f
Compare
Co-authored-by: Weny Xu <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
proto pr: GreptimeTeam/greptime-proto#199
What's changed and what's your intention?
The patch splits the alter commands of
SET FULLTEXT [WITH <options>]
andUNSET FULLTEXT
into different enum for simplicity.Also forbids to change column fulltext options if it has been set before to avoid unexpected query results, e.g.
will fail, since the third alter will change the analyzer.
Checklist