Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: require cmake >= 3.5 #19

Merged
merged 1 commit into from
Jan 26, 2024
Merged

build: require cmake >= 3.5 #19

merged 1 commit into from
Jan 26, 2024

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Jan 13, 2024

With cmake-3.27.9:

CMake Deprecation Warning at CMakeLists.txt:17 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

With cmake-3.27.9:

CMake Deprecation Warning at CMakeLists.txt:17 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
@orbea orbea changed the title build: require cmake > 3.5 build: require cmake >= 3.5 Jan 13, 2024
@orbea
Copy link
Contributor Author

orbea commented Jan 25, 2024

@Grumbel If you have time I would really appreciate if you can review this.

@Grumbel Grumbel merged commit ae5dc56 into Grumbel:master Jan 26, 2024
1 check passed
@orbea orbea deleted the cmake branch January 26, 2024 16:10
orbea added a commit to orbea/gentoo that referenced this pull request Jan 27, 2024
orbea added a commit to orbea/gentoo that referenced this pull request Jan 27, 2024
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Feb 13, 2024
Upstream-PR: Grumbel/sdl-jstest#19
Upstream-Commit: Grumbel/sdl-jstest@ae5dc56
Signed-off-by: orbea <[email protected]>
Closes: #35034
Signed-off-by: Joonas Niilola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants