Rework the compression library search #5085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 2. Medium ⏹
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
|
The search path for libs can be controlled by CMake system variables - see https://cmake.org/cmake/help/latest/command/find_package.html |
release_docs/INSTALL_CMake.txt
Outdated
| @@ -68,7 +68,7 @@ Download from https://github.com/HDFGroup/hdf5/blob/develop/config/cmake/scripts | |||
| External compression plugin libraries from https://github.com/HDFGroup/hdf5_plugins: | |||
| hdf5_plugins.tar.gz | |||
|
|
|||
| External compression szip and zlib libraries: | |||
| External compression szip and zlib libraries:0 | |||
release_docs/RELEASE.txt
Outdated
| @@ -50,7 +50,7 @@ New Features | |||
| - Renamed the option: HDF5_ENABLE_Z_LIB_SUPPORT | |||
|
|
|||
| The option has been renamed to HDF5_ENABLE_ZLIB_SUPPORT to be consistent | |||
| with the naming of other options. | |||
| with the naming of other options. Also, the option defaults to OFF. | |||
There was a problem hiding this comment.
Definitely want to make sure this is very well called out for the next release
lrknox
previously approved these changes
Dec 2, 2024
mattjala
reviewed
Dec 2, 2024
| @@ -3,7 +3,13 @@ HDF5 version 2.0.0 currently under development | |||
| Features included for the next major release: | |||
| ---------------------------------------------------------------------------- | |||
|
|
|||
| * | |||
| ************ Renamed the option: HDF5_ENABLE_Z_LIB_SUPPORT ************ | |||
There was a problem hiding this comment.
Could we break this into two items, with one indicating the rename and one indicating that it now defaults to off? We'd want someone skimming the headlines to catch both of these
mattjala
reviewed
Dec 2, 2024
|
|
||
| The option has been renamed to HDF5_ENABLE_ZLIB_SUPPORT to be consistent | ||
| with the naming of other options. | ||
| *** Also, the option defaults to OFF. This requires the user to explicitly *** |
There was a problem hiding this comment.
Same idea about breaking this into two items
|
I suggest we transition from using txt files to markdown, enabling us to highlight important information more effectively by the use of: |
lrknox
previously approved these changes
Dec 5, 2024
lrknox
previously approved these changes
Dec 11, 2024
jhendersonHDF
previously approved these changes
Dec 13, 2024
lrknox
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default names for search use.