Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'unused parameter' warnings in C++ tests #5199

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fix 'unused parameter' warnings in C++ tests #5199

merged 1 commit into from
Jan 2, 2025

Conversation

derobins
Copy link
Member

@derobins derobins commented Jan 2, 2025

No description provided.

@derobins derobins added Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - C++ C++ wrappers Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels Jan 2, 2025
@derobins
Copy link
Member Author

derobins commented Jan 2, 2025

I'm not super excited about maintaining the C++ wrappers, but while they exist they should at least compile quietly.

qkoziol
qkoziol reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@qkoziol qkoziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the "unused" attribute?

@jhendersonHDF
Copy link
Collaborator

This was something I missed when updating the testing frameworks since I don't usually build with the wrappers on, but like @qkoziol mentioned, using the unused attribute macro like everywhere else that got update seems better

@derobins
Copy link
Member Author

derobins commented Jan 2, 2025

The unused macros aren't public and we avoid H5private.h in the C++ wrappers

@derobins derobins merged commit ed082ac into HDFGroup:develop Jan 2, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkoziol qkoziol qkoziol left review comments

@byrnHDF byrnHDF byrnHDF approved these changes

@hyoklee hyoklee hyoklee approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@bmribler bmribler

Labels
Component - C++ C++ wrappers Component - Testing Code in test or testpar directories, GitHub workflows Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@derobins @jhendersonHDF @hyoklee @qkoziol @byrnHDF @bmribler