Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: RXTE Lightcurve Notebook — Runtime and Error Handling Improvements #20

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

WizardEternal
Copy link

Overview

This pull request proposes an updated version of the analysis-rxte-lightcurve.md notebook. The primary focus of these changes is to improve runtime efficiency, enhance error handling, and introduce an offset calculation that may be useful for future analyses. The goal is to ensure smoother execution of long jobs while maintaining the original functionality of the notebook.


Key Changes

  • Runtime Improvements: Reduced execution time by approximately 14% on average, with up to a 29% reduction observed on the default Eta Car dataset. These changes were achieved through optimizations in file handling, I/O operations, and multiprocessing logic.
  • Error Handling: Added logic to manage edge cases, such as missing files, empty data, or unexpected issues, allowing the process to continue running instead of failing.
  • Offset Calculation: Introduced an offset calculation to measure the arc distance between the target position and the observed position. This value is included in the dataframe output, as it could be useful for researchers working with position-dependent analyses.

Notes for Reviewers

This PR is submitted as a Draft to allow for open discussion and feedback. I’m happy to make adjustments based on your guidance. Please let me know if any part of the logic or documentation needs further clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant