feat(client): use max http version of client by default instead of http 1.1 #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/use-max-version-by-default
branch
from
5ae70dd to
35eb6e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when creating a request, it's default to HTTP1.1 (which is the default value for this field), end user have to explicitly set the version to HTTP2 / HTTP3.
Which makes the following comment
By default request's HTTP version depends on network streamwrong since it will always use HTTP1.1 by defaultNew behavior will use the max http version of the client by default and downgrade to one that it supported (was already the case, but changed the comment to point it out).
Downside of this, is when HTTP3 is enabled and in max version it may timeout.
I'm also wondering if this should be renamed to
max_http_versionfor the request method it may reflect better the intention behind that.