Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jdlnolen extensions r6 #114

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Jdlnolen extensions r6 #114

wants to merge 4 commits into from

Conversation

jdlnolen
Copy link
Collaborator

@jdlnolen jdlnolen commented Jul 5, 2024

OO extension work for R6

lmckenzi
lmckenzi requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@lmckenzi lmckenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejection doesn't happen on the ServiceRequest, it happens via Task - and there's already a statusReason there. A given ServiceRequest might be rejected by 2 different performers and accepted by a third. Don't think this extension makes sense to add.

grahamegrieve
grahamegrieve reviewed Jul 27, 2024
View reviewed changes
Copy link
Contributor

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you making this change?

@jdlnolen
Copy link
Collaborator Author

why are you making this change?

I removed the extension for FHIR-43105 based on feedback from Lloyd. The other changes are for FHIR-41308 to fix the search parameter.

@grahamegrieve
Copy link
Contributor

That task + thread doesn't explain why this change, which I think is wrong. Not letting it into ballot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamegrieve grahamegrieve grahamegrieve left review comments

@lmckenzi lmckenzi lmckenzi requested changes

@brianpos brianpos Awaiting requested review from brianpos brianpos is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdlnolen @grahamegrieve @lmckenzi