Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed a relative text-only URL to a full URL in the NamingSystemIdentifierType codesystem #3205

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaurav
Copy link
Contributor

@gaurav gaurav commented Oct 31, 2024

HL7 FHIR Pull Request

Note: No pull requests will be accepted against ./source unless logged in the HL7 Jira issue tracker.

If you made changes to any files within ./source please indicate the Jira tracker number this pull request is associated with: FHIR-42696

Description

Please describe your pull request here.

As per FHIR-42696, this PR changes a relative text-only URL (rdf.html#iri-stem) to a full URL (http://hl7.org/fhir/rdf.html#iri-stem).

@grahamegrieve
Copy link
Collaborator

why is this a good change? I believe it is a wrong change to make. And which committee authorised it?

@gaurav gaurav marked this pull request as draft November 2, 2024 20:49
@gaurav
Copy link
Contributor Author

gaurav commented Nov 2, 2024

@grahamegrieve Sorry if I skipped a step, Grahame! I'm used to the UTG/Terminology procedures, where a PR is created before submitting an issue for review. The FHIR ticket associated with this change (https://jira.hl7.org/browse/FHIR-42696) has been triaged as Highest priority since last September, so I though that creating a PR for it might help people evaluate it and then decide if it's a worthwhile change or to reject it. I'll move this PR back into Draft status and -- if you'd like -- I could close it and/or delete it as well.

As to why it is a good change, other entries on http://hl7.org/fhir/R5/codesystem-namingsystem-identifier-type.html use absolute URLs (http://unitsofmeasure.org), even for HL7 resources (http://www.hl7.org/Special/committees/vocab/table_0396/index.cfm), which is why I assumed (incorrectly?) that the reference to rdf.html should be absolute as well. Since these local references are not converted into links, I was unsure if a reader would know to copy and paste the local reference into the current URL to get to that location in the FHIR documentation. But if this is the standard for local references in FHIR, then absolutely this entry should follow that guideline as well, and the proposed change (https://jira.hl7.org/browse/FHIR-42696) should be rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants