Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Update StopPlace seed data #969

Draft
wants to merge 2 commits into
base: StopModelRefactoring
Choose a base branch
from

Conversation

suvikankare
Copy link
Contributor

@suvikankare suvikankare commented Dec 18, 2024

Discussion in slack.


This change is Reviewable

@suvikankare suvikankare force-pushed the update-data-model/update-seed-data branch 4 times, most recently from 07c0cfe to c77f031 Compare December 18, 2024 16:44
@Huulivoide
Copy link
Contributor

Pikanen katsastus alkaa vaikuttaa OK:lta.
Main:in sijaan PR:n vois kohdistaa äsken luomaani StopModelRefactoring haaraan, niin pidetään main kunnossa ja toiminnassa kunnes kaikki refaktoroinnit on valmiina, ja voidaan sit kaikki yhdellä kertaa viedä main:iin.

@suvikankare suvikankare changed the base branch from main to StopModelRefactoring December 19, 2024 09:03
Copy link
Contributor

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @suvikankare)


test-db-manager/src/datasets/stopRegistry/stopArea.ts line 139 at r2 (raw file):

const finnooSeedData: StopAreaSeedData = {
  nameFin: 'Finnoo',
  nameSwe: 'Finnoo',

På svenskt har Finnoo bara ett o: Finno


test-db-manager/src/datasets/stopRegistry/stopArea.ts line 63 at r2 (raw file):

    validityStart: basicStart,
    validityEnd: basicEnd,
    members: ['H1398', 'H1416'],

Mihinkäs jäsen pysäkit on kadonneet? Ja näillä pysäkkialuellakin pitäs olla edelleen voimassaolo aika 🤔

@suvikankare suvikankare force-pushed the update-data-model/update-seed-data branch from c77f031 to f342faa Compare December 19, 2024 12:04
@suvikankare suvikankare force-pushed the update-data-model/update-seed-data branch from f342faa to 8073f02 Compare December 23, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants