Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix common substitute day tests #971

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix common substitute day tests #971

merged 1 commit into from
Dec 19, 2024

Conversation

culka
Copy link
Contributor

@culka culka commented Dec 18, 2024 •
edited
Loading

  • Add a wait for the success toast to clear
  • Clear the common substitute day list before filtering

This change is Reviewable

@culka
Fix common substitute day tests
adef306 
- Add a wait for the success toast to clear
- Clear the common substitute day list before filtering
@culka culka force-pushed the fix-common-substitute-day-tests branch from 3ed5b96 to adef306 Compare December 19, 2024 06:10
Huulivoide
Huulivoide approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @culka)

@culka culka merged commit be51beb into main Dec 19, 2024
10 checks passed
@culka culka deleted the fix-common-substitute-day-tests branch December 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huulivoide Huulivoide Huulivoide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@culka @Huulivoide