-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation of Methodology to Hindi #1569
Conversation
…rchive/almanac.httparchive.org into hi-2019 Merge HTTPArchive:main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
A couple of minor things to change and then we can merge this.
|
||
{% block twitter_image_alt %}{{ year }} Web Almanac की कार्यप्रणाली{% endblock %} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra line to keep line numbers consistent with English
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did you know you can just accept the suggested changes in GitHub? Though where there are a few it's sometimes easier to make the changes locally and do one commit and push.
Anyway all good now and merging.
I noticed that GitHub now supports batching suggested changes in the web UI too! Especially helpful when there are lots of comments :) |
Thanks for working on this @PraveenPal4232 I'm excited to add support for a new language! 🚀 |
Yes, I know. But I prefer to do it manually. This way we have few and relevant commits for the same piece of code. |
Welcome, @rviscomi. Pleasure is all mine :) |
For issue #1402