Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of Methodology to Hindi #1569

Merged
merged 10 commits into from
Nov 23, 2020
Merged

Conversation

PraveenPal4232
Copy link
Contributor

  • Added hi/2019/methodology.html
  • Added hi/2020/methodology.html
  • Move chapter templates

For issue #1402

@PraveenPal4232 PraveenPal4232 added the translation world wide web label Nov 23, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

A couple of minor things to change and then we can merge this.


{% block twitter_image_alt %}{{ year }} Web Almanac की कार्यप्रणाली{% endblock %}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line to keep line numbers consistent with English

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/templates/hi/2019/methodology.html Outdated Show resolved Hide resolved
src/templates/hi/2020/methodology.html Outdated Show resolved Hide resolved
src/templates/hi/2020/methodology.html Outdated Show resolved Hide resolved
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did you know you can just accept the suggested changes in GitHub? Though where there are a few it's sometimes easier to make the changes locally and do one commit and push.

Anyway all good now and merging.

@tunetheweb tunetheweb merged commit 6a0093d into HTTPArchive:main Nov 23, 2020
@rviscomi
Copy link
Member

Though where there are a few it's sometimes easier to make the changes locally and do one commit and push.

I noticed that GitHub now supports batching suggested changes in the web UI too! Especially helpful when there are lots of comments :)

@rviscomi
Copy link
Member

Thanks for working on this @PraveenPal4232 I'm excited to add support for a new language! 🚀

@PraveenPal4232
Copy link
Contributor Author

LGTM

Did you know you can just accept the suggested changes in GitHub? Though where there are a few it's sometimes easier to make the changes locally and do one commit and push.

Yes, I know. But I prefer to do it manually. This way we have few and relevant commits for the same piece of code.

@PraveenPal4232
Copy link
Contributor Author

Thanks for working on this @PraveenPal4232 I'm excited to add support for a new language! 🚀

Welcome, @rviscomi. Pleasure is all mine :)
And Thanks to you to take this great insensitive for the web community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants