[Enhancement] Fast Song Playback #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Patrick12115 <[email protected]>
|
There is a conflict with Do not Reset Time Speed. timeSpeedOffset value is hardcoded so when SoT is played it doesn't retain the speed value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up all song playback, including skipping cutscenes for certain songs and elegy statue spawning.
This will most likely still need work, including moving everything that can be, into hooks. I am just still not knowledgeable enough to figure out the hooks myself, so I will need help with that part. Right now everything is just using CVars, which I know is undesirable.
Song of Time reset may be able to be done more elegantly, this was just the only way I, myself, could figure out how to get it to work properly.
Added lots of comments to explain everything as best as I could.
Reupload of #444
Build Artifacts