[Enhancement] EasyMaskEquip #755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckinlee
changed the title
|
I think this is already in a pretty good working state so I'm just gonna go ahead and change this to ready for review. I don't foresee this having to many issues, but please do report any bugs you may find. |
mckinlee
changed the title
… plus moved CHECK_GIVEN_MASK_ON_MOON to macros.h
mckinlee
force-pushed
the
easymaskequip
branch
from
5a50f24 to
4f08dac
Compare
…r is busy with an action
… any mask in the air when wearing a transformation mask
- Streamlined mask selection logic with helper functions - Added grayscale indicators for unavailable masks in the UI - Optimized vertex handling for mask border rendering - Improved game hook integrations for reliable mask equipping - Enhanced code readability and maintainability
…kinian into easymaskequip
…kinian into easymaskequip
|
I realize ShouldEquipMask may not account for all scenarios, but its a good start. I would need help identifying what else we may need to add. |
… any mask in the air when wearing a transformation mask
- Streamlined mask selection logic with helper functions - Added grayscale indicators for unavailable masks in the UI - Optimized vertex handling for mask border rendering - Improved game hook integrations for reliable mask equipping - Enhanced code readability and maintainability
…k for giant's mask
…kinian into easymaskequip
Co-Authored-By: Garrett Cox <[email protected]>
|
63 commits later and I think I've gotten this to a state I'm happy with. I don't plan to make any more changes unless the devs request otherwise. Hope yall like it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EasyMaskEquip is a feature that allows players to quickly equip masks without needing to assign them to C-buttons or D-pad slots. It simplifies the process by letting players equip masks directly from the pause menu. The enhancement also provides visual feedback by highlighting the currently equipped mask and graying out masks that can't be equipped in certain situations (e.g., underwater or mid-transformation).
This PR introduces the EasyMaskEquip enhancement, allowing players to equip masks directly from the pause menu by pressing the A button.A new OnKaleidoClose hook was added to handle mask equipping when the pause menu is closed. This allows players to change their mask selection if they accidentally select the wrong one, ensuring the mask is only equipped once the pause menu is closed.
This enhancement also utilizes Proxy's BeforeKaleidoDrawPage hook from PR #537 to allocate and update vertex data for the mask equip border.Build Artifacts