Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Cycle Arrows #901

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

mckinlee
Copy link
Contributor

@mckinlee mckinlee commented Dec 22, 2024

This enhancement adds a simple way to switch between Normal, Fire, Ice, and Light Arrows when holding the bow. Pressing the L button cycles through any magic arrows the player currently owns, as long as there is enough magic available. If the player runs out of magic, the system automatically swaps back to Normal Arrows.

  • Cycling Arrows: Press L while holding the bow to rotate through available arrow types.
  • Magic Use: Magic is only consumed when releasing a magic arrow, not while drawing it.
  • Fallback: If the player cannot afford a magic arrow, the game reverts to Normal Arrows.
  • Button Flash: The equipped button briefly flashes to highlight the arrow change.
  • Minimap Toggle Blocked: The minimap toggle is disabled when the player is drawing the bow to avoid conflicts.

Build Artifacts

@mckinlee mckinlee changed the title [Enhancement] Cycle arrows [Enhancement] Cycle Arrows Dec 22, 2024
@Archez
Copy link
Contributor

Archez commented Dec 26, 2024

  • Magic Use: Magic is only consumed when releasing a magic arrow, not while drawing it.
  • Fallback: If the player cannot afford a magic arrow, the game reverts to Normal Arrows.

Instead of changing the behavior of magic consumption, could we instead just "give back" the consumed magic if the arrow was switched without firing? Seems like that would simplify some of the handling, like auto switching to normal arrows, since the game naturally makes magic arrows fire as normal without the proper magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants