-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Cycle Arrows #901
Open
mckinlee
wants to merge
21
commits into
HarbourMasters:develop
Choose a base branch
from
mckinlee:cycle-arrows
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+292
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: sitton76 <[email protected]>
Instead of changing the behavior of magic consumption, could we instead just "give back" the consumed magic if the arrow was switched without firing? Seems like that would simplify some of the handling, like auto switching to normal arrows, since the game naturally makes magic arrows fire as normal without the proper magic. |
Co-Authored-By: Archez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement adds a simple way to switch between Normal, Fire, Ice, and Light Arrows when holding the bow. Pressing the L button cycles through any magic arrows the player currently owns, as long as there is enough magic available. If the player runs out of magic, the system automatically swaps back to Normal Arrows.
Build Artifacts