macOS Game Mode Support for Ship of Harkinian #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved the directory & file creation and existence logic out of ship and into port. |
Hopefully it will go from obese to normal weight now.
Removed the unused bash script as well as the reference to it.
|
I believe the LUS PR you were waiting on has been merged, but I'm waiting on another LUS bump PR. You're welcome to put the LUS bump in here, but I don't know if there are implications for where Kenix had his PR's reference vs latest main. |
|
I think the best path forward is to wait for the LUS bump and go from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the necessary changes by Archez and me to the packaging-2.cmake and info.plist files that will allow Game Mode support in Ship of Harkinian.
Should not be merged until https://github.com/Kenix3/libultraship/pull/690 gets merged into Shipwright.
Build Artifacts