-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Ganondorf boss battle intro #4693
base: develop
Are you sure you want to change the base?
Skip Ganondorf boss battle intro #4693
Conversation
Does this still play the Light Arrow and Master Sword hint if they are relevent? |
That's a rando thing, I take it? |
Yes,that should be fine then. |
We should probably remove the “is always skipped in rando” side of this IMO. |
If I understood correctly, what Jordan was saying is that everything skipped here was already always skipped in Rando. |
Oh, you mean have rando rely on this instead of always skipping? |
Right, part of the “vbify” process is to rip out any IS_RANDO things we have forced on for rando, then make them available to both rando and vanilla using a less invasive approach. i don’t necessarily think it should block this PR, but that’s typically how I’ve chunked things together in the past. |
Here's my understanding of the situation. |
It wouldn't be any more problematic than other skips we've converted to the VB flow.
|
So, you're saying rando should still always skip this, just not with a hardcoded check? |
Also worth mentioning, what rando skips, Boss Rush also skips. Are there hook handlers for boss rush so we can remove those hardcoded checks too? |
No, I'm saying there should be no rando-specific check at all. It should also respond to the selections in time savers. Ostensibly this should also work for Boss Rush if the hardcodes are taken out for that. Would probably be good to check if the VB gets checked in BR. |
To be fair, there is a good chance we might have to set BR up to have its own VB handler function like rando does for that, since the rush is a time attack thing by nature and the skips could make a big difference either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the cutscene was allowed to play in rando with the skips off, but I don't want to force that on this PR as there may need to be a redesign of the hint, and this does what it wants to in vanilla just fine.
Right now it just "skips" the intro in the same manner as the other boss intro skips, i.e. pre-emptively setting the flag. In future I'd like to see it skip right to Ganondorf hovering.
Build Artifacts