Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Ganondorf boss battle intro #4693

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JordanLongstaff
Copy link
Contributor

@JordanLongstaff JordanLongstaff commented Dec 15, 2024

Right now it just "skips" the intro in the same manner as the other boss intro skips, i.e. pre-emptively setting the flag. In future I'd like to see it skip right to Ganondorf hovering.

Build Artifacts

@Pepper0ni
Copy link
Contributor

Does this still play the Light Arrow and Master Sword hint if they are relevent?

@JordanLongstaff
Copy link
Contributor Author

That's a rando thing, I take it?
I'd presume so. Everything that gets skipped as a result of this, is always skipped in rando.

@Pepper0ni
Copy link
Contributor

That's a rando thing, I take it? I'd presume so. Everything that gets skipped as a result of this, is always skipped in rando.

Yes,that should be fine then.

@garrettjoecox
Copy link
Contributor

We should probably remove the “is always skipped in rando” side of this IMO.

@Malkierian
Copy link
Contributor

If I understood correctly, what Jordan was saying is that everything skipped here was already always skipped in Rando.

@Malkierian
Copy link
Contributor

Oh, you mean have rando rely on this instead of always skipping?

@garrettjoecox
Copy link
Contributor

Right, part of the “vbify” process is to rip out any IS_RANDO things we have forced on for rando, then make them available to both rando and vanilla using a less invasive approach.

i don’t necessarily think it should block this PR, but that’s typically how I’ve chunked things together in the past.

@JordanLongstaff
Copy link
Contributor Author

JordanLongstaff commented Dec 16, 2024

Here's my understanding of the situation.
@Pepper0ni is concerned that Ganondorf might give a hint in rando during his opening monologue before the boss fight, which this setting would skip.
My take is, there's no concern there because rando always skips the monologue anyway.
Now @garrettjoecox is saying we should change that, which would make this an issue.

@Malkierian
Copy link
Contributor

It wouldn't be any more problematic than other skips we've converted to the VB flow.

  1. This has a cutscene skip VB associated with it for vanilla operation which covers the same stuff that rando always skips.
  2. Proxy is saying rando and non rando should be unified, like other skips do, because there's no difference between what rando skips and what this skips, and there shouldn't be any hardcoded IS_RANDO checks for skips anyway.

@JordanLongstaff
Copy link
Contributor Author

So, you're saying rando should still always skip this, just not with a hardcoded check?
There are multiple hardcoded checks in here, and I'd like to tackle them all if I can.

@JordanLongstaff
Copy link
Contributor Author

Also worth mentioning, what rando skips, Boss Rush also skips. Are there hook handlers for boss rush so we can remove those hardcoded checks too?

@Malkierian
Copy link
Contributor

So, you're saying rando should still always skip this, just not with a hardcoded check? There are multiple hardcoded checks in here, and I'd like to tackle them all if I can.

No, I'm saying there should be no rando-specific check at all. It should also respond to the selections in time savers. Ostensibly this should also work for Boss Rush if the hardcodes are taken out for that. Would probably be good to check if the VB gets checked in BR.

@Malkierian
Copy link
Contributor

To be fair, there is a good chance we might have to set BR up to have its own VB handler function like rando does for that, since the rush is a time attack thing by nature and the skips could make a big difference either way.

Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the cutscene was allowed to play in rando with the skips off, but I don't want to force that on this PR as there may need to be a redesign of the hint, and this does what it wants to in vanilla just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants