Port over ShipInit from 2Ship #4756
Open
+108
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pepe20129
reviewed
Dec 24, 2024
|
CVAR defines updated and also passed along a function inside the COND_ instead so Intellisense is actually useful (ty proxy :)) |
Pepe20129
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says, ports over the ShipInit changes from Proxy over from 2Ship to SoH. Only includes a converted Moon Jump for now to confirm it works. Eventually we'd want to transfer everything from hook_handlers.cpp etc to separate files like this and use this new pattern, but that'll be a while.
I want this in now because I want to start creating a couple of example PRs how enhancements etc should look using hooks, and I really want to start doing that with the new macros. That way we can direct people with existing PRs to the new examples as well instead of having to say "please use hooks instead" with no or little direction.
Build Artifacts