Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BUILDING.md #79

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update BUILDING.md #79

wants to merge 3 commits into from

Conversation

Hitokun
Copy link

@Hitokun Hitokun commented Dec 27, 2024

Update output path for Starship when following instructions on OS X

Update output path for Starship when following instructions on OS X
@fac3l3ss79
Copy link

I would also suggest updating instructions for systems like the raspberry pi 4 & 5 to use "cmake -H. -Bbuild-cmake -GNinja -DUSE_OPENGLES=1"

@JeodC
Copy link

JeodC commented Dec 27, 2024

Feel free to add to this with the following I used for debian bookworm: https://github.com/JeodC/PortMaster-Starship/blob/main/starship/BUILDING.md

I did not actually need to use tinyxml2.so.10, I used the .so.9 version that came bundled with bookworm and it seems to work fine,

I added a step to copy and rename the rom into the working dir for OSX build instructions. ExtractAssets will fail if there's no baserom.us.rev1.z64
@Hitokun
Copy link
Author

Hitokun commented Dec 28, 2024

I would also suggest updating instructions for systems like the raspberry pi 4 & 5 to use "cmake -H. -Bbuild-cmake -GNinja -DUSE_OPENGLES=1"

Would this be distro agnostic?

@Hitokun
Copy link
Author

Hitokun commented Dec 28, 2024

Feel free to add to this with the following I used for debian bookworm: https://github.com/JeodC/PortMaster-Starship/blob/main/starship/BUILDING.md

I did not actually need to use tinyxml2.so.10, I used the .so.9 version that came bundled with bookworm and it seems to work fine,

I guess we could add a section for Bookworm/ARM64 under Linux instructions, would it be ok to just yank it from your instructions. Or maybe a link to your repo would suffice?

@JeodC
Copy link

JeodC commented Dec 28, 2024

Feel free to add to this with the following I used for debian bookworm: https://github.com/JeodC/PortMaster-Starship/blob/main/starship/BUILDING.md

I did not actually need to use tinyxml2.so.10, I used the .so.9 version that came bundled with bookworm and it seems to work fine,

I guess we could add a section for Bookworm/ARM64 under Linux instructions, would it be ok to just yank it from your instructions. Or maybe a link to your repo would suffice?

No need to link, take what you like.

Copy link

@jtrees jtrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add build instructions for ARM64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants