Skip to content

Commit

Permalink
Restore CfOverride
Browse files Browse the repository at this point in the history
  • Loading branch information
@kLabz
kLabz committed Dec 17, 2024
1 parent e384b4e commit bbcfa43
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/typing/typeloadFields.ml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1248,6 +1248,7 @@ let create_method (ctx,cctx,fctx) c f cf fd p =
end;
let is_override = Option.is_some fctx.override in
if (is_override && fctx.is_static) then invalid_modifier_combination fctx ctx.com fctx "override" "static" p;
if is_override then add_class_field_flag cf CfOverride;

ctx.type_params <- params @ ctx.type_params;
let args,ret = setup_args_ret ctx cctx fctx (fst f.cff_name) fd p in
Expand Down

1 comment on commit bbcfa43

@Simn
Copy link
Member

@Simn Simn commented on bbcfa43 Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be branched a bit nicer because we have the if is_override twice in a row.

Please sign in to comment.