Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS time stamps to published JointState messages #92

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Add ROS time stamps to published JointState messages #92

merged 1 commit into from
Jul 3, 2018

Conversation

josephcoombe
Copy link
Contributor

@josephcoombe josephcoombe commented Jun 27, 2018

Added to support common ROS (visualization) tools that parse the JointState.Header.time field.


e.g.
rosrun rqt_plot rqt_plot /hebiros/GROUP_NAME/feedback/joint_state/effort[1]

^ fyi, rqt_plot has an known issue caused by a failure to distinguish between namespaces and fields - causing this example to fail sometimes since hebiros defines a feedback msg.

See: ros-visualization/rqt_plot#7

Not suggesting you should change that. Just mentioning it.

Copy link
Contributor

@iamtesch iamtesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we may want to use the simulation time from gazebo, but I think this is good for now.

@iamtesch iamtesch merged commit 3ef69c8 into HebiRobotics:develop Jul 3, 2018
@josephcoombe josephcoombe deleted the add-ros-time-stamps-to-published-joint-states branch July 6, 2018 14:44
@josephcoombe
Copy link
Contributor Author

Eventually, we may want to use the simulation time from gazebo, but I think this is good for now.

If you set the /use_sim_time param to True before launching a ROS Node (note: that parameters designated in a launch file are loaded before launching nodes), then ROS Time will be the same as simulation time.

See: http://wiki.ros.org/Clock#Using_Simulation_Time_from_the_.2BAC8-clock_Topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants