✅ 添加测试：更新与添加插件

[AkashiCoin]

Summary by Sourcery

通过为 zhenxun 机器人框架添加插件管理和更新检查的新测试来增强测试套件。重构测试配置以使用动态标识符，提高测试的灵活性和可维护性。

新功能：

• 在 zhenxun 机器人框架中引入用于添加和更新插件的新测试，增强插件管理功能的测试覆盖率。

增强：

• 重构测试配置以使用动态用户和机器人 ID，提高测试设置的灵活性和可维护性。

测试：

• 为 plugin_store 和 auto_update 功能添加全面测试，包括添加基本和额外插件以及检查更新的场景。

Original summary in English

Summary by Sourcery

Enhance the test suite by adding new tests for plugin management and update checking in the zhenxun bot framework. Refactor test configurations to use dynamic identifiers, improving test flexibility and maintainability.

New Features:

• Introduce new tests for adding and updating plugins in the zhenxun bot framework, enhancing the test coverage for plugin management functionalities.

Enhancements:

• Refactor the test configuration to use dynamic user and bot IDs, improving the flexibility and maintainability of the test setup.

Tests:

• Add comprehensive tests for the plugin_store and auto_update functionalities, including scenarios for adding basic and extra plugins, and checking for updates.

[sourcery-ai]

Sourcery 审核指南

此拉取请求为插件商店和自动更新功能添加了新的测试用例，更新了 conftest.py 文件以改进测试设置，并对自动更新数据源文件进行了小幅更改。更改的重点是增强测试覆盖率和改进整体测试基础设施。

文件级更改

更改	详情	文件
更新了 conftest.py 以改进测试设置和配置	添加了对 json、typing 和 collections.abc 的导入 实现了 get_response_json 函数以加载 JSON 测试数据 使用更详细的配置更新了 pytest_configure 添加了 _init_bot fixture 以注册适配器和加载插件 更新了 app fixture 以包括数据库初始化和清理 添加了 create_bot 和 mocked_api fixtures	tests/conftest.py
为插件商店功能添加了新的测试用例	实现了 test_add_plugin_basic 以测试添加基本插件 实现了 test_add_plugin_extra 以测试添加额外插件 为插件商店端点添加了模拟 API 响应 创建了用于生成测试事件和消息的实用函数	tests/builtin_plugins/plugin_store/test_add_plugin.py tests/utils.py
为自动更新功能添加了新的测试用例	实现了 test_check_update_release 以测试更新检查过程 为 GitHub 发布端点添加了模拟 API 响应 创建了用于加载测试数据和生成测试事件的实用函数	tests/builtin_plugins/auto_update/test_check_update.py tests/utils.py
添加了用于在测试中模拟 API 调用的 JSON 响应文件	创建了 release_latest.json 用于 GitHub 发布数据 创建了 basic_plugins.json 和 extra_plugins.json 用于插件商店数据 添加了 github_sub_plugin_api.json 和 github_sub_plugin_contents.json 用于 GitHub API 响应 添加了 search_image_plugin_api.json 用于搜索图像插件数据	tests/response/release_latest.json tests/response/basic_plugins.json tests/response/extra_plugins.json tests/response/github_sub_plugin_api.json tests/response/github_sub_plugin_contents.json tests/response/search_image_plugin_api.json
添加了测试常量的配置文件	创建了 BotId、UserId、GroupId 和 MessageId 类 定义了在测试用例中使用的常量值	tests/config.py
更新了自动更新数据源文件	在删除下载文件和提取路径之前移动了临时文件的关闭 (tf.close())	zhenxun/builtin_plugins/auto_update/_data_source.py

---

提示

• 通过在拉取请求中评论 @sourcery-ai review 来触发新的 Sourcery 审核。
• 通过直接回复审核评论继续与 Sourcery 的讨论。
• 您可以随时通过访问您的仪表板来更改您的审核设置：
  • 启用或禁用 Sourcery 生成的拉取请求摘要或审核指南；
  • 更改审核语言；
• 如果您有任何问题或反馈，您可以随时联系我们。

Original review guide in English

Reviewer's Guide by Sourcery

This pull request adds new test cases for the plugin store and auto-update features, updates the conftest.py file to improve test setup, and makes a minor change to the auto-update data source file. The changes focus on enhancing the test coverage and improving the overall testing infrastructure.

File-Level Changes

Change	Details	Files
Updated conftest.py to improve test setup and configuration	Added imports for json, typing, and collections.abc Implemented get_response_json function to load JSON test data Updated pytest_configure with more detailed configuration Added _init_bot fixture to register adapters and load plugins Updated app fixture to include database initialization and cleanup Added create_bot and mocked_api fixtures	tests/conftest.py
Added new test cases for the plugin store feature	Implemented test_add_plugin_basic to test adding a basic plugin Implemented test_add_plugin_extra to test adding an extra plugin Added mock API responses for plugin store endpoints Created utility functions for generating test events and messages	tests/builtin_plugins/plugin_store/test_add_plugin.py tests/utils.py
Added new test cases for the auto-update feature	Implemented test_check_update_release to test the update checking process Added mock API responses for GitHub release endpoints Created utility functions for loading test data and generating test events	tests/builtin_plugins/auto_update/test_check_update.py tests/utils.py
Added JSON response files for mocking API calls in tests	Created release_latest.json for GitHub release data Created basic_plugins.json and extra_plugins.json for plugin store data Added github_sub_plugin_api.json and github_sub_plugin_contents.json for GitHub API responses Added search_image_plugin_api.json for search image plugin data	tests/response/release_latest.json tests/response/basic_plugins.json tests/response/extra_plugins.json tests/response/github_sub_plugin_api.json tests/response/github_sub_plugin_contents.json tests/response/search_image_plugin_api.json
Added configuration file for test constants	Created classes for BotId, UserId, GroupId, and MessageId Defined constant values for use in test cases	tests/config.py
Updated auto-update data source file	Moved the closing of the temporary file (tf.close()) before deleting the download file and extract path	zhenxun/builtin_plugins/auto_update/_data_source.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

嘿 @AkashiCoin - 我已经审查了你的更改，它们看起来很棒！

这是我在审查期间查看的内容

• 🟢 一般问题：一切看起来都很好
• 🟢 安全性：一切看起来都很好
• 🟡 测试：发现4个问题
• 🟢 复杂性：一切看起来都很好
• 🟢 文档：一切看起来都很好

---

Sourcery 对开源项目免费 - 如果你喜欢我们的审查，请考虑分享它们 ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{帮助我变得更有用！请点击 👍 或 👎 在每个评论上告诉我它是否有帮助。}

Original comment in English

Hey @AkashiCoin - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟡 Testing: 4 issues found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion (testing): 考虑为 get_response_json 函数添加类型提示

添加类型提示可以提高代码可读性并及早捕获潜在的类型相关错误。考虑为 get_response_json 函数添加返回类型提示。

Original comment in English

suggestion (testing): Consider adding type hints to the get_response_json function

Adding type hints can improve code readability and catch potential type-related errors early. Consider adding a return type hint to the get_response_json function.

[sourcery-ai]

suggestion (testing): 为添加插件的预期副作用添加断言

虽然测试检查了 API 调用是否已进行，但它没有验证添加插件的副作用，例如检查插件文件是否实际创建在预期位置。考虑添加这样的断言以使测试更全面。

async def test_add_plugin_basic(
    app: App,
    mocker: MockerFixture,
    mocked_api: MockRouter,
    create_bot: Callable,
    tmp_path: Path,
) -> None:
    # ... (existing code)

    assert mocked_api["basic_plugins"].called
    assert mocked_api["extra_plugins"].called
    assert mocked_api["search_image_plugin_api"].called
    assert mocked_api["search_image_plugin_file_init"].called
    assert (tmp_path / "plugins" / "search_image").exists()
    assert (tmp_path / "plugins" / "search_image" / "__init__.py").is_file()

Original comment in English

suggestion (testing): Add assertions for the expected side effects of adding a plugin

While the test checks if the API calls were made, it doesn't verify the side effects of adding a plugin, such as checking if the plugin files were actually created in the expected location. Consider adding such assertions to make the test more comprehensive.

async def test_add_plugin_basic(
    app: App,
    mocker: MockerFixture,
    mocked_api: MockRouter,
    create_bot: Callable,
    tmp_path: Path,
) -> None:
    # ... (existing code)

    assert mocked_api["basic_plugins"].called
    assert mocked_api["extra_plugins"].called
    assert mocked_api["search_image_plugin_api"].called
    assert mocked_api["search_image_plugin_file_init"].called
    assert (tmp_path / "plugins" / "search_image").exists()
    assert (tmp_path / "plugins" / "search_image" / "__init__.py").is_file()

[sourcery-ai]

suggestion (testing): 为不同的更新场景添加测试用例

当前测试仅涵盖了有更新可用的场景。考虑为没有更新可用或更新过程中出现错误的场景添加测试用例。

Original comment in English

suggestion (testing): Add test cases for different update scenarios

The current test only covers the scenario where an update is available. Consider adding test cases for scenarios where no update is available, or when there's an error during the update process.

[sourcery-ai]

suggestion (testing): 为文件操作添加错误处理

实用函数 get_response_json 和 get_content_bytes 没有任何错误处理。考虑添加 try-except 块来处理潜在的文件相关错误，例如 FileNotFoundError。

def get_response_json(path: str) -> dict:
    try:
        file_path = Path(__file__).parent / "response" / path
        return json.loads(file_path.read_text(encoding="utf8"))
    except (FileNotFoundError, json.JSONDecodeError) as e:
        raise ValueError(f"Error reading or parsing JSON file: {e}")

def get_content_bytes(path: str) -> bytes:
    try:
        return (Path(__file__).parent / "content" / path).read_bytes()
    except FileNotFoundError as e:
        raise ValueError(f"Error reading file: {e}")

Original comment in English

suggestion (testing): Add error handling for file operations

The utility functions get_response_json and get_content_bytes don't have any error handling. Consider adding try-except blocks to handle potential file-related errors, such as FileNotFoundError.

def get_response_json(path: str) -> dict:
    try:
        file_path = Path(__file__).parent / "response" / path
        return json.loads(file_path.read_text(encoding="utf8"))
    except (FileNotFoundError, json.JSONDecodeError) as e:
        raise ValueError(f"Error reading or parsing JSON file: {e}")

def get_content_bytes(path: str) -> bytes:
    try:
        return (Path(__file__).parent / "content" / path).read_bytes()
    except FileNotFoundError as e:
        raise ValueError(f"Error reading file: {e}")