✨ 签到/金币排行限制最大数量

[HibiKier]

Summary by Sourcery

在签到和金币排行榜中实现对可显示条目最大数量的限制，限制为50。

增强功能：

• 将签到和金币排行榜中的最大条目数量限制为50。

Original summary in English

Summary by Sourcery

Implement a restriction on the maximum number of entries that can be displayed in the sign-in and gold ranking lists, capping it at 50.

Enhancements:

• Limit the maximum number of entries in the sign-in and gold ranking lists to 50.

[sourcery-ai]

审核指南由 Sourcery 提供

此拉取请求实现了对签到和金币排行榜中条目数量的最大限制。它还包括对命令结构和错误处理的一些小改进。

文件级更改

更改	详情	文件
为排行榜实现最大50条目限制	添加检查以限制签到排行榜中的条目数量为50 添加检查以限制金币排行榜中的条目数量为50 当请求的条目数量超过50时显示错误信息	zhenxun/builtin_plugins/sign_in/__init__.py zhenxun/builtin_plugins/shop/__init__.py
改进命令结构和参数处理	将签到列表命令中的 'num' 参数更改为可选，默认值为10 更新金币列表子命令以要求 'num' 参数 在两个插件中使用 AlconnaQuery 处理 'num' 参数	zhenxun/builtin_plugins/sign_in/__init__.py zhenxun/builtin_plugins/shop/__init__.py
增强私聊场景的错误处理	添加检查以防止在私聊中查看特定群组的排行榜 在尝试在私聊中查看排行榜时显示适当的错误信息	zhenxun/builtin_plugins/shop/__init__.py

---

提示

• 通过在拉取请求上评论 @sourcery-ai review 触发新的 Sourcery 审核。
• 通过直接回复审核评论继续与 Sourcery 的讨论。
• 您可以随时通过访问您的仪表板更改审核设置：
  • 启用或禁用 Sourcery 生成的拉取请求摘要或审核指南；
  • 更改审核语言；
• 如果您有任何问题或反馈，您可以随时联系我们。

Original review guide in English

Reviewer's Guide by Sourcery

This pull request implements a limit on the maximum number of entries in the sign-in and gold coin ranking lists. It also includes some minor improvements to the command structure and error handling.

File-Level Changes

Change	Details	Files
Implement a maximum limit of 50 entries for ranking lists	Add a check to limit the number of entries to 50 in the sign-in ranking list Add a check to limit the number of entries to 50 in the gold coin ranking list Display an error message when the requested number of entries exceeds 50	zhenxun/builtin_plugins/sign_in/__init__.py zhenxun/builtin_plugins/shop/__init__.py
Improve command structure and parameter handling	Change the 'num' parameter in sign-in list command to be optional with a default value of 10 Update the gold-list subcommand to require the 'num' parameter Use AlconnaQuery for handling the 'num' parameter in both plugins	zhenxun/builtin_plugins/sign_in/__init__.py zhenxun/builtin_plugins/shop/__init__.py
Enhance error handling for private chat scenarios	Add a check to prevent viewing group-specific rankings in private chats Display an appropriate error message when trying to view rankings in private chats	zhenxun/builtin_plugins/shop/__init__.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

嗨 @HibiKier - 我已经审查了你的更改，看起来很棒！

这是我在审查期间查看的内容

• 🟡 一般问题：发现2个问题
• 🟢 安全性：一切看起来都很好
• 🟢 测试：一切看起来都很好
• 🟢 复杂性：一切看起来都很好
• 🟢 文档：一切看起来都很好

---

Sourcery 对开源项目免费 - 如果你喜欢我们的审查，请考虑分享它们 ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{帮助我变得更有用！请点击 👍 或 👎 在每个评论上告诉我它是否有帮助。}

Original comment in English

Hey @HibiKier - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: 考虑为最大排名限制定义一个常量

为了提高可维护性和一致性，考虑在模块级别定义一个常量，如 MAX_RANK_LIMIT = 50，并在此处和其他类似检查中使用它。

MAX_RANK_LIMIT = 50

# ... (earlier in the file)

    if num.result > MAX_RANK_LIMIT:

Original comment in English

suggestion: Consider defining a constant for the maximum rank limit

To improve maintainability and consistency, consider defining a constant like MAX_RANK_LIMIT = 50 at the module level and using it here and in other similar checks.

MAX_RANK_LIMIT = 50

# ... (earlier in the file)

    if num.result > MAX_RANK_LIMIT:

[sourcery-ai]

suggestion: 考虑将私信检查通用化

此私信检查对其他命令也可能有用。考虑创建一个装饰器或实用函数来处理此检查，可以在不同的命令处理程序中重用。

async def check_private_message(gid: Optional[int], action: str):
    if not gid:
        await MessageUtils.build_message(
            f"私聊中无法查看 '{action}'，请发送 '{action}总排行'"
        ).finish()

if not arparma.find("all"):
    await check_private_message(gid, "金币排行")

Original comment in English

suggestion: Consider generalizing the private message check

This check for private messages could be useful for other commands as well. Consider creating a decorator or utility function to handle this check, which could be reused across different command handlers.

async def check_private_message(gid: Optional[int], action: str):
    if not gid:
        await MessageUtils.build_message(
            f"私聊中无法查看 '{action}'，请发送 '{action}总排行'"
        ).finish()

if not arparma.find("all"):
    await check_private_message(gid, "金币排行")