More Homebrew .pkg improvements
#16082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test on more macOS versions and improve the test names - add a more resilient and less disruptive version of changing `git`'s `safe.directory` configuration
|
Not sure I get the point of |
Bo98
approved these changes
Oct 5, 2023
Avoids unsetting if it was not set as it seems to check/break the user's GitHub configuration in some cases. Thanks for review @Bo98 |
|
Right yeah I follow the logic now, yeah. Initially thought it was some stack-based thing (multiple adds followed by multiple removals). Your explanation makes sense now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git'ssafe.directoryconfiguration