workflows/tests: split gem cache per OS version #16089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Good catch here, nice work @Bo98.
Good to try bootsnap PR again after this?
|
Should be, yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is fairly safe to install a gem built on Ubuntu 20.04 on later versions like 22.04, it is not safe to install a gem built on Ubuntu 22.04 on earlier versions like 20.04. The same applies to macOS too, albeit sometimes more discretely.
Easiest fix to that is to split the cache further. We probably want to re-test the initial compile once every new OS version anyway to make sure new compilers/headers/etc remain compatible.