Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/parser: depopulate commands' internal args lists #16096

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Each command's args was including both options and their descriptions. This trims them down to including just short and long options.

Before: (for e.g. brew --cache's args)

==> #<Homebrew::CLI::Args named=[], remaining=[], d?=true, debug?=true, Display any debugging information.?=false, q?=false, quiet?=false, Make some output more quiet.?=false, v?=false, verbose?=false, Make some output more verbose.?=false, ...

After:

==> #<Homebrew::CLI::Args named=[], remaining=[], d?=true, debug?=true, q?=false, quiet?=false, v?=false, verbose?=false, h?=false, help?=false, os=nil, arch=nil, s?=false, build_from_source?=false, force_bottle?=false, bottle_tag=nil, HEAD?=false, formula?=false, formulae?=false, cask?=false, casks?=false>

@apainintheneck
Copy link
Contributor

How did you find this?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @EricFromCanada!

@MikeMcQuaid MikeMcQuaid enabled auto-merge October 8, 2023 18:13
@MikeMcQuaid MikeMcQuaid merged commit 5349b76 into Homebrew:master Oct 8, 2023
27 checks passed
@EricFromCanada
Copy link
Member Author

How did you find this?

Accidentally while odebugging for another issue.

@EricFromCanada EricFromCanada deleted the cli-args-extras branch October 9, 2023 01:09
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants