-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tips-N'-Tricks: homebrew.man.conf for Terminal.app #16099
Conversation
Add instructions for fixing Terminal.app's "Open man Page" command by creating homebrew.man.conf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far @heller! A few suggestions.
Update instructions: Append to the file from the shell, and fix permissions if on macOS Intel. Co-authored-by: Mike McQuaid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestions, thank you!
@heller, @MikeMcQuaid As noted in Issue #16074, I am working through some additional (hopefully, well thought-out & relevant) comments for your consideration.
I would appreciated being allowed this week for adding such comments before the issue is closed out. Would this be possible? Thanks. |
Reopening tickets in case of new information seems normal to me, but I defer to maintainers. |
@marc-medley Let's keep discussing the issue once it's closed and, if necessary and there's something additionally actionable beyond this PR, we'll reopen. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your first contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock, @heller!
Add instructions for fixing Terminal.app's "Open man Page" command by creating homebrew.man.conf.
Fixes #16074.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?