fix(docs): update fish completions command #16160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apainintheneck
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
This makes sense to me. I use fish as well but I installed it from brew. Looking at my fish_complete_path I was able to see that the brew completions come after the builtin fish ones. When I changed the order of those two directories the completions stopped working for me.
| end | ||
|
|
||
| if test -d (brew --prefix)"/share/fish/vendor_completions.d" | ||
| set -gx fish_complete_path $fish_complete_path (brew --prefix)/share/fish/vendor_completions.d | ||
| set -p fish_complete_path (brew --prefix)/share/fish/vendor_completions.d |
There was a problem hiding this comment.
Locally for me the brew completions are in this location.
|
Thanks for the help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
fishconfiguration that should be used in order for shell completions provided frombrewto work.As the docs explain, with the current command completions inside
(brew --prefix)/share/fishare appended tofish_complete_path, but sincefishwill use the first available file, we want(brew --prefix)/share/fishto be prepended instead.Closes #16159. Given my explanation above, I think that what was happening is that this file was being used instead of the "real" one vendored by
brew.