Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fish completions of brew bundle #16317

Merged

Conversation

yoshida-ryuhei
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Current status

  • Current improvement of fish completions in brew bundle does not support all the sub commands, like install, list.

Change

  • Add fish completions for brew bundle install/list.

@yoshida-ryuhei yoshida-ryuhei marked this pull request as draft December 12, 2023 07:02
@yoshida-ryuhei yoshida-ryuhei force-pushed the dev/update_completions_bundle branch from 4eeead1 to 64fc295 Compare December 12, 2023 07:07
@yoshida-ryuhei yoshida-ryuhei marked this pull request as ready for review December 12, 2023 07:10
@yoshida-ryuhei
Copy link
Contributor Author

I missed the automatic generation of the shell completion file, but it has been corrected.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @yoshida-ryuhei!

@MikeMcQuaid MikeMcQuaid merged commit 9b58b12 into Homebrew:master Dec 12, 2023
24 checks passed
@yoshida-ryuhei yoshida-ryuhei deleted the dev/update_completions_bundle branch December 12, 2023 09:03
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants