Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide default gems warnings for Ruby 3.4. #17315

Merged
merged 1 commit into from
May 17, 2024
Merged

Hide default gems warnings for Ruby 3.4. #17315

merged 1 commit into from
May 17, 2024

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented May 16, 2024 •
edited
Loading

These omit warnings with Ruby 3.3 and are required for Ruby 3.4. We'll fix them when we're upgrading to 3.4 instead.

@Bo98 Bo98 force-pushed the portable-ruby-3.3.1 branch 2 times, most recently from a13d8d6 to f2ebef0 Compare May 16, 2024 23:23
@Bo98 Bo98 force-pushed the portable-ruby-3.3.1 branch 3 times, most recently from ddb0c39 to 64f60bb Compare May 17, 2024 01:58
@MikeMcQuaid MikeMcQuaid force-pushed the portable-ruby-3.3.1 branch 3 times, most recently from 9576a7b to 727cf5e Compare May 17, 2024 03:32
Base automatically changed from portable-ruby-3.3.1 to master May 17, 2024 03:42
@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review May 17, 2024 04:20
@MikeMcQuaid MikeMcQuaid enabled auto-merge May 17, 2024 04:20
@carlocab
Copy link
Member 

<internal:/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.1/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require': cannot load such file -- /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/base64-0.2.0/lib/base64.rb (LoadError)

@MikeMcQuaid MikeMcQuaid changed the title Add gems to Gemfile for Ruby 3.4. Hide default gems warnings for Ruby 3.4. May 17, 2024
@carlocab carlocab changed the title Hide default gems warnings for Ruby 3.4. Hide default gem warnings for Ruby 3.4. May 17, 2024
@carlocab carlocab changed the title Hide default gem warnings for Ruby 3.4. Hide default gems warnings for Ruby 3.4. May 17, 2024
@MikeMcQuaid
Copy link
Member Author

Changed approach here after chatting with @Bo98 on Slack to just hide the warnings until 3.4.

@MikeMcQuaid
Hide default gems warnings for Ruby 3.4.
a408da6 
These omit warnings with Ruby 3.3 and are required for Ruby 3.4. We'll
fix them when we're upgrading to 3.4 instead.
@MikeMcQuaid MikeMcQuaid merged commit c269524 into master May 17, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the 3.4-gems branch May 17, 2024 05:53
@MikeMcQuaid MikeMcQuaid mentioned this pull request May 21, 2024
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @carlocab @Bo98