Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi_formula_mappings: normalize PyPI package names #167128

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 25, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Normalizing all names (https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization).

We already do this resource names via brew update-python-resources

Planning to audit this in Homebrew/brew#16800

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Mar 25, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 25, 2024
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Mar 25, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Mar 25, 2024
Merged via the queue into master with commit 3179c98 Mar 25, 2024
18 checks passed
@chenrui333 chenrui333 deleted the pypi_formula_mappings-normalize branch March 25, 2024 18:56
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants