Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndpi 4.12 #202050

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ndpi 4.12 #202050

wants to merge 2 commits into from
+3 −3

Conversation

chenrui333
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

release notes 
## Major Changes


For further details on these three topics, see https://www.ntop.org/ntop/a-deep-dive-into-traffic-fingerprints/


New Supported Protocols and Services


This is the list of the new supported protocols, grouped by category.

Information about these new protocols is available on https://github.com/ntop/nDPI/blob/dev/doc/protocols.rst



New features



New algorithms



New configuration knobs


Further information is available on https://github.com/ntop/nDPI/blob/dev/doc/configuration_parameters.md



Improvements



Misc



New Contributors



Full Changelog: ntop/nDPI@4.10...4.12

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 21, 2024
@alebcay
Copy link
Member

alebcay commented Dec 21, 2024 

  clang++ -fpie -fno-color-diagnostics   -g -O2 -I/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2 -I/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include -I /opt/homebrew/include -Wall -I/usr/local/include -std=c++1y -I/opt/homebrew/Cellar/hiredis/1.2.0/include/hiredis -I/opt/homebrew/Cellar/hiredis/1.2.0/include -D_FILE_OFFSET_BITS=64 -I/usr/include/hiredis -I/opt/homebrew/Cellar/libmaxminddb/1.11.0/include -I/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/third-party/mongoose -I/opt/homebrew/Cellar/json-c/0.18/include -I/opt/homebrew/Cellar/json-c/0.18/include/json-c   -I/opt/homebrew/opt/ndpi/include/ndpi -I/opt/homebrew/opt/ndpi/include/ndpi/../lib/third_party/include -I/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/third-party/lua-5.4.6/src -I/opt/homebrew/Cellar/rrdtool/1.9.0/include  -I/opt/homebrew/Cellar/mariadb-connector-c/3.4.3/include/mariadb -I/opt/homebrew/Cellar/mariadb-connector-c/3.4.3/include/mariadb/mysql -I/opt/homebrew/Cellar/zeromq/4.3.5_1/include -I/opt/homebrew/Cellar/libsodium/1.0.20/include -g -O2 -I/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2 -I/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include -Wno-address-of-packed-member -Wno-unused-function -I /opt/homebrew/include -I/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/third-party/http-client-c/src/ -I/opt/homebrew/Cellar/openssl@3/3.4.0/include -I/usr/include/openssl  -DDATA_DIR='"/opt/homebrew/Cellar/ntopng/6.2_2/share"'  -c src/AggregatedFlowsStats.cpp -o src/AggregatedFlowsStats.o
  In file included from src/AggregatedFlowsStats.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:389:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/NetworkInterface.h:536:24: error: use of undeclared identifier 'ndpi_get_protocol_id'; did you mean 'ndpi_get_proto_by_id'?
    536 |     u_int16_t _proto = ndpi_get_protocol_id(get_ndpi_struct(), proto);
        |                        ^~~~~~~~~~~~~~~~~~~~
        |                        ndpi_get_proto_by_id
  /opt/homebrew/opt/ndpi/include/ndpi/ndpi_api.h:713:16: note: 'ndpi_get_proto_by_id' declared hereIn file included from src/ActiveHostWalkerInfo.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:389:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/NetworkInterface.h:536:24: error: use of undeclared identifier 'ndpi_get_protocol_id'; did you mean 'ndpi_get_proto_by_id'?
    536 |     u_int16_t _proto = ndpi_get_protocol_id(get_ndpi_struct(), proto);
        |                        ^~~~~~~~~~~~~~~~~~~~
        |                        ndpi_get_proto_by_id
  /opt/homebrew/opt/ndpi/include/ndpi/ndpi_api.h:713:16: note: 'ndpi_get_proto_by_id' declared here
    713 |   extern char* ndpi_get_proto_by_id(struct ndpi_detection_module_struct *ndpi_mod, u_int id);
        |                ^
  In file included from src/ActiveHostWalkerInfo.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:389:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/NetworkInterface.h:536:64: error: cannot initialize a parameter of type 'u_int' (aka 'unsigned int') with an lvalue of type 'char *'
    536 |     u_int16_t _proto = ndpi_get_protocol_id(get_ndpi_struct(), proto);
        |                                                                ^~~~~
  /opt/homebrew/opt/ndpi/include/ndpi/ndpi_api.h:713:90: note: passing argument to parameter 'id' here
    713 |   extern char* ndpi_get_proto_by_id(struct ndpi_detection_module_struct *ndpi_mod, u_int id);
        |                                                                                          ^
  
    713 |   extern char* ndpi_get_proto_by_id(struct ndpi_detection_module_struct *ndpi_mod, u_int id);
        |                ^
  In file included from src/AggregatedFlowsStats.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:389:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/NetworkInterface.h:536:64: error: cannot initialize a parameter of type 'u_int' (aka 'unsigned int') with an lvalue of type 'char *'
    536 |     u_int16_t _proto = ndpi_get_protocol_id(get_ndpi_struct(), proto);
        |                                                                ^~~~~
  /opt/homebrew/opt/ndpi/include/ndpi/ndpi_api.h:713:90: note: passing argument to parameter 'id' here
    713 |   extern char* ndpi_get_proto_by_id(struct ndpi_detection_module_struct *ndpi_mod, u_int id);
        |                                                                                          ^
  In file included from src/AddressTree.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:389:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/NetworkInterface.h:536:24: error: use of undeclared identifier 'ndpi_get_protocol_id'; did you mean 'ndpi_get_proto_by_id'?
    536 |     u_int16_t _proto = ndpi_get_protocol_id(get_ndpi_struct(), proto);
        |                        ^~~~~~~~~~~~~~~~~~~~
        |                        ndpi_get_proto_by_id
  /opt/homebrew/opt/ndpi/include/ndpi/ndpi_api.h:713:16: note: 'ndpi_get_proto_by_id' declared here
    713 |   extern char* ndpi_get_proto_by_id(struct ndpi_detection_module_struct *ndpi_mod, u_int id);
        |                ^
  In file included from src/AddressTree.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:389:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/NetworkInterface.h:536:64: error: cannot initialize a parameter of type 'u_int' (aka 'unsigned int') with an lvalue of type 'char *'
    536 |     u_int16_t _proto = ndpi_get_protocol_id(get_ndpi_struct(), proto);
        |                                                                ^~~~~
  /opt/homebrew/opt/ndpi/include/ndpi/ndpi_api.h:713:90: note: passing argument to parameter 'id' here
    713 |   extern char* ndpi_get_proto_by_id(struct ndpi_detection_module_struct *ndpi_mod, u_int id);
        |                                                                                          ^
  In file included from src/AddressResolution.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:389:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/NetworkInterface.h:536:24: error: use of undeclared identifier 'ndpi_get_protocol_id'; did you mean 'ndpi_get_proto_by_id'?
    536 |     u_int16_t _proto = ndpi_get_protocol_id(get_ndpi_struct(), proto);
        |                        ^~~~~~~~~~~~~~~~~~~~
        |                        ndpi_get_proto_by_id
  /opt/homebrew/opt/ndpi/include/ndpi/ndpi_api.h:713:16: note: 'ndpi_get_proto_by_id' declared here
    713 |   extern char* ndpi_get_proto_by_id(struct ndpi_detection_module_struct *ndpi_mod, u_int id);
        |                ^
  In file included from src/AddressResolution.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:389:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/NetworkInterface.h:536:64: error: cannot initialize a parameter of type 'u_int' (aka 'unsigned int') with an lvalue of type 'char *'
    536 |     u_int16_t _proto = ndpi_get_protocol_id(get_ndpi_struct(), proto);
        |                                                                ^~~~~
  /opt/homebrew/opt/ndpi/include/ndpi/ndpi_api.h:713:90: note: passing argument to parameter 'id' here
    713 |   extern char* ndpi_get_proto_by_id(struct ndpi_detection_module_struct *ndpi_mod, u_int id);
        |                                                                                          ^
  In file included from src/AddressResolution.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:481:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:452:36: error: no member named 'master_protocol' in 'ndpi_proto'
    452 |     return (((ndpiDetectedProtocol.master_protocol == p) ||
        |               ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:453:36: error: no member named 'app_protocol' in 'ndpi_proto'
    453 |              (ndpiDetectedProtocol.app_protocol == p)) ? true : false);
        |               ~~~~~~~~~~~~~~~~~~~~ ^
  In file included from src/ActiveHostWalkerInfo.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:481:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:452:36: error: no member named 'master_protocol' in 'ndpi_proto'
    452 |     return (((ndpiDetectedProtocol.master_protocol == p) ||
        |               ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:509:74: error: no member named 'app_protocol' in 'ndpi_proto'
    509 |     return (cli_ps == device_pr/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:453:36: error: no member named 'app_protocol' in 'ndpi_proto'
    453 |              (ndpiDoto_forbidden_app) ? ndpiDetectedProtocol.app_protocol
        |                                                     ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:510:39: error: no member named 'master_protocol' in 'ndpi_proto'
    510 |                : ndpiDetectedProtocoletectedProtocol.app_protocol == p)) ? true : false);
        |               ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:509:74: error: no member named 'app_protocol' in 'ndpi_proto'
    509 |     return (cli_ps == device_proto_forbidden_app) ? ndpiDetectedProtocol.app_protocol
        |                                                     ~~~~~~~~~~~~~~~~~~~~ ^
  .master_proto/private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:510:39: error: no member named 'master_protocol' in 'ndpi_proto'
    510 |                : ndpiDetectedProtocol.master_protocolcol;
        |                  ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:515:74: error: no member named 'app_protocol' in 'ndpi_proto'
    515 |     return (srv_ps == device_proto_forbidden_app) ? ndpiDetectedProtocol.app_protocol
        |                                                     ~~~~~~~~~~~~~~~~~~~~ ^
  In file included from src/AggregatedFlowsStats.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:481:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:516:39: error: no member named 'master_protocol' in 'ndpi_proto'
  ;
          | 516                 ~~~~~~~~~~~~~~~~~~~~ ^ | 
                 : ndpiDetectedProtocol.master_protocol;
        |                  ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:515:74: error: no member named 'app_protocol' in 'ndpi_proto'
    515 |     return (srv_ps == device_proto_forbidden_app) ? ndpiDetectedProtocol.app_protocol
        |                                                     ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:516:39: error: no member named 'master_protocol' in 'ndpi_proto'
    516 |                : ndpiDetectedProtocol.master_protocol;
        |                  ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:452:36: error: no member named 'master_protocol' in 'ndpi_proto'
    452 |     return (((ndpiDetectedProtocol.master_protocol == p) ||
        |               ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:453:36: error: no member named 'app_protocol' in 'ndpi_proto'
    453 |              (ndpiDetectedProtocol.app_protocol == p)) ? true : false);
        |               ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:509:74: error: no member named 'app_protocol' in 'ndpi_proto'
    509 |     return (cli_ps == device_proto_forbidden_app) ? ndpiDetectedProtocol.app_protocol
        |                                                     ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:510:39: error: no member named 'master_protocol' in 'ndpi_proto'
    510 |                : ndpiDetectedProtocol.master_protocol;
        |                  ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:515:74: error: no member named 'app_protocol' in 'ndpi_proto'
    515 |     return (srv_ps == device_proto_forbidden_app) ? ndpiDetectedProtocol.app_protocol
        |                                                     ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:516:39: error: no member named 'master_protocol' in 'ndpi_proto'
    516 |                : ndpiDetectedProtocol.master_protocol;
        |                  ~~~~~~~~~~~~~~~~~~~~ ^
  In file included from src/AddressTree.cpp:22:
  In file included from /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/ntop_includes.h:481:
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:452:36: error: no member named 'master_protocol' in 'ndpi_proto'
    452 |     return (((ndpiDetectedProtocol.master_protocol == p) ||
        |               ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:453:36: error: no member named 'app_protocol' in 'ndpi_proto'
    453 |              (ndpiDetectedProtocol.app_protocol == p)) ? true : false);
        |               ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:509:74: error: no member named 'app_protocol' in 'ndpi_proto'
    509 |     return (cli_ps == device_proto_forbidden_app) ? ndpiDetectedProtocol.app_protocol
        |                                                     ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:510:39: error: no member named 'master_protocol' in 'ndpi_proto'
    510 |                : ndpiDetectedProtocol.master_protocol;
        |                  ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:515:74: error: no member named 'app_protocol' in 'ndpi_proto'
    515 |     return (srv_ps == device_proto_forbidden_app) ? ndpiDetectedProtocol.app_protocol
        |                                                     ~~~~~~~~~~~~~~~~~~~~ ^
  /private/tmp/ntopng-20241221-15527-3iqazl/ntopng-6.2/include/Flow.h:516:39: error: no member named 'master_protocol' in 'ndpi_proto'
    516 |                : ndpiDetectedProtocol.master_protocol;
        |                  ~~~~~~~~~~~~~~~~~~~~ ^
  8 errors generated.
  make: *** [src/AggregatedFlowsStats.o] Error 1
  make: *** Waiting for unfinished jobs....
  8 errors generated.
  8 errors generated.
  make: *** [src/AddressResolution.o] Error 1
  make: *** [src/ActiveHostWalkerInfo.o] Error 1
  8 errors generated.
  make: *** [src/AddressTree.o] Error 1

@alebcay alebcay added the build failure CI fails while building the software label Dec 21, 2024
@daeho-ro
Copy link
Member

Tried to patch several commits but it getting worse. Have to wait for the next release for ntopng.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @alebcay @daeho-ro