Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1240: Prevent resizing of already loaded images due to original dimensions in results #6101

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

juliosgarbi
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

This PR addresses an issue where images that are already loaded are being resized based on their original_width and original_height from results data. The incorrect precedence of sizes from results is causing potential bugs in the display of images and regions.

With the introduction of Multi Image Labeling (MIG), functionality was added to detect image size from regions information to ensure proper display even if the image wasn't loaded yet.

What does this fix?

Ensure that if an image is already loaded, it should not be resized based on regions information.

@github-actions github-actions bot added the fix label Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit dc3cf69
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/669666f2c40c7700081be74c

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit dc3cf69
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/669666f2ab6d1a0008bf8ad1

@juliosgarbi juliosgarbi merged commit d1b4486 into develop Jul 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants