Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LEAP-1314: Remove Stale Feature Flag - fflag_feat_front_dev… #6732

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Nov 27, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Removing a FF that was stale for a few months.

WHEN REVIEW
CHECK THE STALE VALUE FIRST

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 38079d6
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6748a44fcfc2e50008a31d44

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 38079d6
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6748a44feb085c000894562c

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (e5c1339) to head (38079d6).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6732      +/-   ##
===========================================
- Coverage    76.73%   76.72%   -0.01%     
===========================================
  Files          170      170              
  Lines        13885    13910      +25     
===========================================
+ Hits         10655    10673      +18     
- Misses        3230     3237       +7     
Flag Coverage Δ
pytests 76.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yyassi-heartex
Copy link
Contributor

yyassi-heartex commented Nov 28, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/core/tsconfig.spec.json

@luarmr luarmr merged commit ca2cd86 into develop Dec 2, 2024
42 of 43 checks passed
@luarmr luarmr deleted the fb-leap-1314/remove-stale-feature-flag---fflagfeatfrontdev2984dmdraggablecolumnsshort branch December 2, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants