Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileReader should initialise Controller Messages from file #22

Open
mifrandir opened this issue Aug 23, 2021 · 0 comments
Open

FileReader should initialise Controller Messages from file #22

mifrandir opened this issue Aug 23, 2021 · 0 comments

Comments

@mifrandir
Copy link
Member

https://github.com/Hyp-ed/hyped-2022/blob/master/src/propulsion/file_reader.cpp, see the comment.

While rewriting, we should remove the C-style code.

  • reference to a vector instead of a raw pointer and a length
  • read file through C++ standard library tools, don't use C style functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant