Weird logic in rpm_regulator.cpp

[TomLonergan03]

In RPM_Regulator::calculateRPM when the temperature is over the maximum temperature the output is to maintain current RPMs. This feels counterintuitive and needs confirmed whether it is correct behaviour.

hyped-2022/src/propulsion/RPM_regulator.cpp

Lines 17 to 32 in f2b3ddc

	if (act_temp <= MAX_TEMP) {
	if (act_current < MAX_CURRENT && act_temp < MAX_TEMP && act_rpm < opt_rpm) {
	return act_rpm + step(opt_rpm, true);
	} else if (act_current > MAX_CURRENT || act_temp > MAX_TEMP || act_rpm > opt_rpm) {
	int32_t target = act_rpm - step(opt_rpm, false);
	if (target < 0) {
	return 0;
	} else {
	return target;
	}
	} else {
	return act_rpm;
	}
	} else {
	return act_rpm;
	}