Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for release preparation #17

Merged
merged 3 commits into from
May 6, 2024

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented May 1, 2024

Fixes Issue

Fixes #8

Changes proposed

  • Create script to automate the next release cycle preparation
  • Create a script to update the version

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr lampajr marked this pull request as draft May 1, 2024 16:30
Copy link

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bunch of small things, and I've offered a few suggestions.

docs/RELEASE.md Outdated Show resolved Hide resolved
docs/RELEASE.md Outdated Show resolved Hide resolved
Comment on lines 41 to 43
```bash
# push main branch
git push origin main
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command should fail, because the origin repo's main branch should be protected against direct pushes -- modifying main (and stable branches) really should require a PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's totally right, I am proceeding step-by-step and at the moment the main is not protected yet as this is still in development mode. Planning to follow your approach in the near future.

The only difference is that this git push origin main will be replaced by creating a new branch and then "create a pull request with those changes"

scripts/next-dev-cycle.sh Outdated Show resolved Hide resolved
scripts/next-dev-cycle.sh Show resolved Hide resolved
scripts/next-dev-cycle.sh Outdated Show resolved Hide resolved
scripts/update-version.sh Outdated Show resolved Hide resolved
scripts/update-version.sh Outdated Show resolved Hide resolved
scripts/update-version.sh Outdated Show resolved Hide resolved
scripts/next-dev-cycle.sh Outdated Show resolved Hide resolved
@lampajr
Copy link
Member Author

lampajr commented May 2, 2024

I found a bunch of small things, and I've offered a few suggestions.

Hi @webbnh , I really appreciate all your suggestions they were really great!!!!

@lampajr lampajr marked this pull request as ready for review May 6, 2024 16:05
@lampajr lampajr changed the title Automate release preparation Add scripts for release preparation May 6, 2024
@lampajr lampajr merged commit 8054533 into Hyperfoil:main May 6, 2024
3 checks passed
@lampajr lampajr deleted the automate_release branch May 6, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Release Process
2 participants