-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts for release preparation #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a bunch of small things, and I've offered a few suggestions.
```bash | ||
# push main branch | ||
git push origin main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command should fail, because the origin
repo's main
branch should be protected against direct push
es -- modifying main
(and stable branches) really should require a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's totally right, I am proceeding step-by-step and at the moment the main is not protected yet as this is still in development mode. Planning to follow your approach in the near future.
The only difference is that this git push origin main
will be replaced by creating a new branch and then "create a pull request with those changes"
Hi @webbnh , I really appreciate all your suggestions they were really great!!!! |
Fixes Issue
Fixes #8
Changes proposed
Check List (Check all the applicable boxes)