-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Lab Permissions Filtering Bug #1371
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt in the rejection controller and a function at the frontend to call that point
hey @pascagihozo do you mind running ```
to make the frontend checks successfully pass |
Thank you @Agaba-derrick |
Thanks @pascagihozo . |
Fixed in thsi PR #1374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
The current implementation fails to properly filter laboratory sections based on user permissions. Users with restricted access are incorrectly shown all lab sections instead of only those they are authorized to view. This security issue allows users to see test sections outside their assigned roles (e.g., a user with only Cytology and Biochemistry permissions can view all labs).
change code snippets
[Add relevant screenshots here if applicable]
Related Issue
[Add a link to the related issue or mention it here if applicable]
Proposed Fix
Update the permission filtering logic in UserServiceImpl to correctly validate and restrict lab section access based on the user's assigned roles and permissions.
[Add any additional information or notes here]
@mozzy11 @caseyi