Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NPM packages #41

Closed
wants to merge 3 commits into from
Closed

Updated NPM packages #41

wants to merge 3 commits into from

Conversation

JAHMCR
Copy link
Contributor

@JAHMCR JAHMCR commented Feb 28, 2023

Updated packages to their latest versions to fix Dependabot alerts

Closes #22

JAHMCRIBM and others added 3 commits February 28, 2023 16:37
Updated packages to their latest versions to fix Dependabot alerts
Defined window.open for jest
Changed Node version to 16
@gegles
Copy link
Member

gegles commented Mar 6, 2023

@dwosk @JAHMCR can we make progress on this?

@gegles gegles requested review from dwosk and a team March 6, 2023 17:27
@gegles gegles self-assigned this Mar 6, 2023
@JAHMCR
Copy link
Contributor Author

JAHMCR commented Mar 6, 2023

@gegles is that WhiteSource scan mandatory? If not, we could just let it pass for now to further look into it with more detail

@dwosk
Copy link
Member

dwosk commented Mar 7, 2023

I propose we carefully go through the various dependencies and update as-needed/one-by-one rather than the broad npm update approach. There are a lot of major version bumps with breaking changes so I'd rather we tackle those on an individual basis - does that make sense?

The Dependabot alerts are all for development dependencies. There aren't any issues with the libraries used in production so I don't think this is really all that urgent.

@dwosk dwosk closed this Jul 14, 2023
@JAHMCR JAHMCR deleted the fix/dependabotalerts branch July 31, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Dependabots alerts
4 participants