-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical Partitioning #407
Draft
xInfinitYz
wants to merge
32
commits into
IEvangelist:main
Choose a base branch
from
xInfinitYz:Feature/Hierarchical-PartitionKeys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Hierarchical Partitioning #407
xInfinitYz
wants to merge
32
commits into
IEvangelist:main
from
xInfinitYz:Feature/Hierarchical-PartitionKeys
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow compilation fresh clone
Feature/hierarchical partition keys Work in Progress
IEvangelist
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good thus far, needs a bit more work. Thanks for contributing this.
src/Microsoft.Azure.CosmosRepository/Builders/ContainerOptionsBuilder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Providers/DefaultCosmosPartitionKeyPathProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Providers/ICosmosPartitionKeyPathProvider.cs
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/DefaultRepository.Batch.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/DefaultRepository.Count.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/DefaultRepository.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/DefaultRepository.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/DefaultRepository.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/DefaultRepository.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/DefaultRepository.cs
Outdated
Show resolved
Hide resolved
…Builder.cs Co-authored-by: David Pine <[email protected]>
…rtitionKeyPathProvider.cs Co-authored-by: David Pine <[email protected]>
…nKeyPathProvider.cs Co-authored-by: David Pine <[email protected]>
…itory.Count.cs Co-authored-by: David Pine <[email protected]>
…itory.cs Co-authored-by: David Pine <[email protected]>
…itory.Count.cs Co-authored-by: David Pine <[email protected]>
…itory.cs Co-authored-by: David Pine <[email protected]>
…itory.cs Co-authored-by: David Pine <[email protected]>
…itory.cs Co-authored-by: David Pine <[email protected]>
…itory.cs Co-authored-by: David Pine <[email protected]>
…itory.Count.cs Co-authored-by: David Pine <[email protected]>
…itory.Exists.cs Co-authored-by: David Pine <[email protected]>
…itory.Paging.cs Co-authored-by: David Pine <[email protected]>
…itory.Read.cs Co-authored-by: David Pine <[email protected]>
…itory.Specs.cs Co-authored-by: David Pine <[email protected]>
…itory.Update.cs Co-authored-by: David Pine <[email protected]>
…om/xInfinitYz/azure-cosmos-dotnet-repository into Feature/Hierarchical-PartitionKeys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first ever PR as a contributor to github and to this project, I'm eager to collaborate and learn. I've proposed some changes related to discussion #332 and #333, aiming to support hierarchical partitioning.
I would greatly appreciate your feedback on the following:
I'm looking forward to your constructive feedback and suggestions to improve this PR. Let's work together to make this integration as smooth as possible.
Tasks
IEnumerable<string> partitionKeyValues
parameter approach is valuable