Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

269 hl7 2024 jan review ihe style conventions regarding numbers in text use of em dashes punctuation quotation marks etc #357

Conversation

JavierEspina
Copy link
Collaborator

@JavierEspina JavierEspina commented Dec 13, 2024

📑 Description

☑ Mandatory Tasks

The following aspects have been respected by the pull request assignee and at least one reviewer:

  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer

Updated per 2024.12.13 SDPi Friday review
Copy link
Collaborator

@ToddCooper ToddCooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes reviewed and approved during the SDPi Friday 2024.12.13 meeting.

@ToddCooper ToddCooper merged commit 929c1e3 into master Dec 13, 2024
1 check passed
@ToddCooper
Copy link
Collaborator

ToddCooper commented Dec 13, 2024

POST-MERGE COMMENT (forgot to add in the rush to get 2.0.0 released):

In the final review and approval of this PR, @JavierEspina explained how he approached the topic & not having been able to have a clear discussion with @MaryLJ beforehand. The group reviewed the changes, the original HL7 JIRA ticket and noted the lack of a formal IHE Style Guide (as stated in the original JIRA ticket), and after that discussion approved the change.

In subsequent email exchanges with Mary Jungers / IHE Documentation Specialist, she confirmed that there is no special IHE Style Guide and that she "tends to follow “The Chicago Manual of Style” conventions".

Therefore, we are confident that the changes applied in this PR fully meet the intent of the original HL7 Ballot commenter, and if not, another ballot may be submitted for the January 2025 cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants