Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move team-related functions to IITC.utils.getTeamId #782

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Move team-related functions to IITC.utils.getTeamId #782

merged 4 commits into from
Nov 19, 2024

Conversation

modos189
Copy link
Contributor

@modos189 modos189 commented Nov 14, 2024 •
edited
Loading

The code has been refactored to combine similar team-related functions into a single utility function IITC.utils.getTeamId.

Changes

  • Combined teamStringToId and getTeam into IITC.utils.getTeamId
  • Added comprehensive tests for team ID conversion logic
  • Marked window.getTeam as deprecated
  • window.getTeam and window.teamStringToId are preserved but marked as deprecated
  • Plugins using the old functions will work without modifications

TODO

  • Update documentation for plugin developers
  • In a separate PR: migrate existing codebase to use the new API

@modos189 modos189 added enhancement New feature or request development general development issue labels Nov 14, 2024
@github-actions GitHub Actions
Copy link

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk 6d50bad
test-0.39.1.20241114.120551.zip 6d50bad

See build on website

@modos189 modos189 merged commit b6c2245 into IITC-CE:master Nov 19, 2024
4 checks passed
@modos189 modos189 deleted the feature/entity-to-utils branch November 19, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xscreach xscreach xscreach approved these changes

Assignees
No one assigned
Labels
development general development issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modos189 @xscreach