Removed SF table clutter in favor of using type metatables.

[davidsonbr]

No description provided.

[Jazzelhawk]

You missed these:
https://github.com/Ingenious-Gaming/Starfall/blob/lib_data_storage_fix/lua/starfall/libs_cl/render.lua#L700

https://github.com/Ingenious-Gaming/Starfall/blob/lib_data_storage_fix/lua/starfall/libs_sh/hook.lua#L69-L73

https://github.com/Ingenious-Gaming/Starfall/blob/lib_data_storage_fix/lua/starfall/libs_sh/net.lua#L87-L93

https://github.com/Ingenious-Gaming/Starfall/blob/lib_data_storage_fix/lua/starfall/libs_sh/players.lua#L5

https://github.com/Ingenious-Gaming/Starfall/blob/lib_data_storage_fix/lua/starfall/libs_sh/players.lua#L27

https://github.com/Ingenious-Gaming/Starfall/blob/lib_data_storage_fix/lua/starfall/libs_sh/vehicle.lua#L20

Also in libs_sh/players.lua you're doing

player_metamethods.__wrap = wrap
player_metamethods.__unwrap = unwrap

but they are already set when doing SF.AddObject(Un)Wrapper. So they aren't needed. Not sure if this is done anywhere else though.
It appears libs_sh/vehicle.lua is doing it aswell

Really good job though btw, lets just hope you didn't accidentally mix up some of the names xD

[awilliamson]

Yeah, will need to be careful about these. Lots of testing. Was thinking about this change only 3 days ago :) good job

[Jazzelhawk]

It also appears to break the ACF-Starfall implementation which kinda sucks but I guess the guys at ACF will just have to do an update.

Edit: Nevermind, looks like you're a step ahead.

[awilliamson]

Will also break any extension addons relying on existing libraries.

[davidsonbr]

Didn't realize SF.AddObject(Un)Wrapper set the __(un)wrap key. Oops.

All other mentioned instances have been fixed.

I'll be on the iG server testing every func if anybody wants to come double-team it.

[awilliamson]

Whilst testing, it might be useful to develop SF scripts as unit-tests for library functions. So if you're doing the work already, might aswell save and post the SF chips "somewhere". Just a thought. Reproducible tests are good.

[davidsonbr]

Forgot about holograms lib. Of course I remember as I am about to leave. Will fix when I return.

[davidsonbr]

Ehh, did it right now and checked all files with regex, did not catch anything with this.

SF.Entities|SF.Angles|SF.Color|SF.Players|SF.SGlobalTables|SF.Sounds|SF.Vectors|SF.Vehicles|SF.VMatrix|SF.Wire|SF.Holograms