utils.IterateOrderedMap for plugin.FormatMessage #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
requested changes
Apr 25, 2024
oxzi
force-pushed
the
plugin-formatmessage-order-i177
branch
from
021059a to
88286ba
Compare
The "Tags" and "Extra Tags" printed in the plugin.FormatMessage were directly read from their map, thus having no order. This resulted in the same NotificationRequest being represented by different messages due to the unordered map. This change was the result of investigating Go's new rangefunc experiment[0]. The utilization of this novel language feature - which can also be indirectly used in the absence of `GOEXPERIMENT=rangefunc` - ensures that the map is traversed in key order. Closes #177. [0]: https://go.dev/wiki/RangefuncExperiment
oxzi
force-pushed
the
plugin-formatmessage-order-i177
branch
from
88286ba to
011fc75
Compare
julianbrost
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Tags" and "Extra Tags" printed in the
plugin.FormatMessagewere directly read from their map, thus having no order. This resulted in the sameNotificationRequestbeing represented by different messages due to the unordered map.This change was the result of investigating Go's new rangefunc experiment. The utilization of this novel language feature - which can also be indirectly used in the absence of
GOEXPERIMENT=rangefunc- ensures that the map is traversed in key order.Closes #177.