Skip to content

Commit

Permalink
roles: Fix default sort rule by name
Browse files Browse the repository at this point in the history
  • Loading branch information
nilmerg committed Nov 5, 2024
1 parent aba56d8 commit 8551fff
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion application/controllers/RoleController.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function listAction()
);
$this->setupLimitControl();
$this->setupPaginationControl($this->view->roles);
$this->setupSortControl($sortAndFilterColumns, $this->view->roles, ['name']);
$this->setupSortControl($sortAndFilterColumns, $this->view->roles);
}

/**
Expand Down
2 changes: 2 additions & 0 deletions library/Icinga/Authentication/RolesConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

class RolesConfig extends IniRepository
{
protected $sortRules = ['name' => ['order' => 'asc']];

Check failure on line 11 in library/Icinga/Authentication/RolesConfig.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 8.2 on ubuntu-latest

Property Icinga\Authentication\RolesConfig::$sortRules type has no value type specified in iterable type array.

Check failure on line 11 in library/Icinga/Authentication/RolesConfig.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 7.4 on ubuntu-latest

Property Icinga\Authentication\RolesConfig::$sortRules type has no value type specified in iterable type array.

Check failure on line 11 in library/Icinga/Authentication/RolesConfig.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 7.3 on ubuntu-latest

Property Icinga\Authentication\RolesConfig::$sortRules type has no value type specified in iterable type array.

Check failure on line 11 in library/Icinga/Authentication/RolesConfig.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 7.2 on ubuntu-latest

Property Icinga\Authentication\RolesConfig::$sortRules type has no value type specified in iterable type array.

Check failure on line 11 in library/Icinga/Authentication/RolesConfig.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 8.3 on ubuntu-latest

Property Icinga\Authentication\RolesConfig::$sortRules type has no value type specified in iterable type array.

Check failure on line 11 in library/Icinga/Authentication/RolesConfig.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 8.0 on ubuntu-latest

Property Icinga\Authentication\RolesConfig::$sortRules type has no value type specified in iterable type array.

Check failure on line 11 in library/Icinga/Authentication/RolesConfig.php

View workflow job for this annotation

GitHub Actions / phpstan / Static analysis with phpstan and php 8.1 on ubuntu-latest

Property Icinga\Authentication\RolesConfig::$sortRules type has no value type specified in iterable type array.

protected $configs = [
'roles' => [
'name' => 'roles',
Expand Down

0 comments on commit 8551fff

Please sign in to comment.