Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent comments in INI files #4932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ledvinap
Copy link

There is minor inconsistency with comment handling in INI file:

dir1 = "I have commentsPost( c1)" ; c1
dir2 = I have no comments ; c2
dir3 = I have commentsPre( c2) from previous line

BTW:
for quoted value, garbage is silently ignored, possibly leading to hard-to-spot problems. Is it worth fixing?

dir = "this is dir value"but this part is ignored"  ; and this is commentsPost

There is minor inconsistency with comment handling in INI file:
```
dir1 = "I have commentsPost(c1)" ; c1
dir2 = I have no comments ; c2
dir3 = I have commentsPre(c2) from previous line
```
@cla-bot
Copy link

cla-bot bot commented Oct 18, 2022

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @ledvinap

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@ledvinap
Copy link
Author

Signed,
but there may be something like 'significant change' filter. At least it is fun signing legalese for contributing 4 (hopefully useful) characters

@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants